[hl] Fix debug assigns not sorted when not optimize #12006

yuxiaomao · 2025-02-12T13:15:34Z

When the optimization is effective, fun.assigns are sorted correctly in ascending order. When no optimization or optimization is not needed in a inner function, arg (-1) seems to be placed before captured var (-2), which cause debugger not treating them correctly.

haxe/src/generators/hlopt.ml

Lines 618 to 619 in 79e018d

    
           let new_assigns = List.sort (fun (_,p1) (_,p2) -> p1 - p2) (List.rev new_assigns) in 
        
           assigns := Array.of_list new_assigns;

Tests in

[CI] add tests for assigns sort vshaxe/hashlink-debugger#137

[hl] Fix debug assigns not sorted when not optimize

221c3ff

yuxiaomao merged commit 2833046 into HaxeFoundation:development Feb 13, 2025
59 checks passed

yuxiaomao deleted the dev-hldebug-sortassign branch February 13, 2025 07:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[hl] Fix debug assigns not sorted when not optimize #12006

[hl] Fix debug assigns not sorted when not optimize #12006

yuxiaomao commented Feb 12, 2025 •

edited

Loading

	let new_assigns = List.sort (fun (_,p1) (_,p2) -> p1 - p2) (List.rev new_assigns) in
	assigns := Array.of_list new_assigns;

[hl] Fix debug assigns not sorted when not optimize #12006

[hl] Fix debug assigns not sorted when not optimize #12006

Conversation

yuxiaomao commented Feb 12, 2025 • edited Loading

yuxiaomao commented Feb 12, 2025 •

edited

Loading